Issue 302923002: Revert of Generate java bindings for constants.

Issue 302923002: Revert of Generate java bindings for constants. (Closed)

Created:
6 years, 6 months ago by Mathieu

Modified:
6 years, 6 months ago

Reviewers:
rmcilroy, bulach, viettrungluu, qsr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, mlamouri (slow - plz ping)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Generate java bindings for constants. (https://codereview.chromium.org/291903003/) Reason for revert: Breaking a bot (Linux Builder (dbg)(32)) Original issue's description: > Generate java bindings for constants. > > This CL is the first CL introducing java bindings. It only generates > constants. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273307 TBR=viettrungluu@chromium.org,bulach@chromium.org,rmcilroy@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273320

Patch Set 1 #

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -263 lines)			Patch
D	mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	mojo/public/tools/bindings/generators/java_templates/constant_definition.tmpl	View	1 chunk	+0 lines, -5 lines	0 comments	Download
D	mojo/public/tools/bindings/generators/java_templates/constants.java.tmpl	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	mojo/public/tools/bindings/generators/java_templates/header.java.tmpl	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	mojo/public/tools/bindings/generators/java_templates/java_macros.tmpl	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	mojo/public/tools/bindings/generators/mojom_java_generator.py	View	1 chunk	+0 lines, -182 lines	0 comments	Download
M	mojo/public/tools/bindings/mojom_bindings_generator.gypi	View	5 chunks	+1 line, -13 lines	0 comments	Download
M	mojo/public/tools/bindings/mojom_bindings_generator.py	View	2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/302923002/1

6 years, 6 months ago (2014-05-28 19:36:48 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages