Issue 3029013: Valgrind: Sort the suppressions list; merge a duplicate; move a few mac only ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3029013: Valgrind: Sort the suppressions list; merge a duplicate; move a few mac only ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Lei Zhang

Modified:
4 years ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Valgrind: Sort the suppressions list; merge a duplicate; move a few mac only suppressions to the right file. BUG=none TEST=none

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM http://codereview.chromium.org/3029013/diff/1/3 File tools/valgrind/memcheck/suppressions_mac.txt (right): http://codereview.chromium.org/3029013/diff/1/3#newcode488 tools/valgrind/memcheck/suppressions_mac.txt:488: fun:CFRunLoopRunSpecific Everything after this frame can go, since ...

4 years, 10 months ago (2010-07-20 21:42:05 UTC) #2

Lei Zhang

http://codereview.chromium.org/3029013/diff/1/3 File tools/valgrind/memcheck/suppressions_mac.txt (right): http://codereview.chromium.org/3029013/diff/1/3#newcode488 tools/valgrind/memcheck/suppressions_mac.txt:488: fun:CFRunLoopRunSpecific On 2010/07/20 21:42:05, stuartmorgan wrote: > Everything after ...

4 years, 10 months ago (2010-07-20 22:23:16 UTC) #3

Lei Zhang

4 years, 10 months ago (2010-07-20 22:25:26 UTC) #4

Err, I caused gcl to misbehave and it reuploaded this as
http://codereview.chromium.org/3022017/show.

Expand Messages | Collapse Messages

Issue 3029013: Valgrind: Sort the suppressions list; merge a duplicate; move a few mac only ... (Closed)

Description

Patch Set 1 #

Messages