Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: Source/modules/indexeddb/IDBRequestTest.cpp

Issue 302893004: Remove V8TestingScope::create (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/TimingInputTest.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/indexeddb/IDBRequestTest.cpp
diff --git a/Source/modules/indexeddb/IDBRequestTest.cpp b/Source/modules/indexeddb/IDBRequestTest.cpp
index 43851600a4f220da3d6ba33e366d28fd80173075..2ddbf31440b5f2e9018c144942a76a75ce6eaed6 100644
--- a/Source/modules/indexeddb/IDBRequestTest.cpp
+++ b/Source/modules/indexeddb/IDBRequestTest.cpp
@@ -74,17 +74,17 @@ NullExecutionContext::NullExecutionContext()
class IDBRequestTest : public testing::Test {
public:
IDBRequestTest()
- : m_scope(V8TestingScope::create(v8::Isolate::GetCurrent()))
+ : m_scope(v8::Isolate::GetCurrent())
{
- m_scope->scriptState()->setExecutionContext(adoptRef(new NullExecutionContext()));
+ m_scope.scriptState()->setExecutionContext(adoptRef(new NullExecutionContext()));
}
- v8::Isolate* isolate() const { return m_scope->isolate(); }
- ScriptState* scriptState() const { return m_scope->scriptState(); }
- ExecutionContext* executionContext() const { return m_scope->scriptState()->executionContext(); }
+ v8::Isolate* isolate() const { return m_scope.isolate(); }
+ ScriptState* scriptState() const { return m_scope.scriptState(); }
+ ExecutionContext* executionContext() const { return m_scope.scriptState()->executionContext(); }
private:
- OwnPtr<V8TestingScope> m_scope;
+ V8TestingScope m_scope;
};
TEST_F(IDBRequestTest, EventsAfterStopping)
« no previous file with comments | « Source/core/animation/TimingInputTest.cpp ('k') | Source/modules/indexeddb/IDBTransactionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698