Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: Source/bindings/v8/ScriptPromiseTest.cpp

Issue 302893004: Remove V8TestingScope::create (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverTest.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromiseTest.cpp
diff --git a/Source/bindings/v8/ScriptPromiseTest.cpp b/Source/bindings/v8/ScriptPromiseTest.cpp
index c8c82f3b3c1a098d4f01815785c544feb9a01bca..817bcfc5cd8540df93ee0045399cb43c39719caa 100644
--- a/Source/bindings/v8/ScriptPromiseTest.cpp
+++ b/Source/bindings/v8/ScriptPromiseTest.cpp
@@ -70,24 +70,24 @@ private:
class ScriptPromiseTest : public testing::Test {
public:
ScriptPromiseTest()
- : m_scope(V8TestingScope::create(v8::Isolate::GetCurrent()))
+ : m_scope(v8::Isolate::GetCurrent())
{
}
~ScriptPromiseTest()
{
// FIXME: We put this statement here to clear an exception from the isolate.
- createClosure(callback, v8::Undefined(m_scope->isolate()), m_scope->isolate());
+ createClosure(callback, v8::Undefined(m_scope.isolate()), m_scope.isolate());
// Execute all pending microtasks
isolate()->RunMicrotasks();
}
- ScriptState* scriptState() const { return m_scope->scriptState(); }
- v8::Isolate* isolate() const { return m_scope->isolate(); }
+ ScriptState* scriptState() const { return m_scope.scriptState(); }
+ v8::Isolate* isolate() const { return m_scope.isolate(); }
protected:
- OwnPtr<V8TestingScope> m_scope;
+ V8TestingScope m_scope;
};
TEST_F(ScriptPromiseTest, constructFromNonPromise)
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolverTest.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698