Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: Source/bindings/v8/ScriptPromiseResolverTest.cpp

Issue 302893004: Remove V8TestingScope::create (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/IDBBindingUtilitiesTest.cpp ('k') | Source/bindings/v8/ScriptPromiseTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromiseResolverTest.cpp
diff --git a/Source/bindings/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/v8/ScriptPromiseResolverTest.cpp
index 1612dccbc8d4a3248dd649153b06f726f62e0be8..8a21cf7896b3371bb278d275528697064f11dbae 100644
--- a/Source/bindings/v8/ScriptPromiseResolverTest.cpp
+++ b/Source/bindings/v8/ScriptPromiseResolverTest.cpp
@@ -64,9 +64,9 @@ private:
class ScriptPromiseResolverTest : public testing::Test {
public:
ScriptPromiseResolverTest()
- : m_scope(V8TestingScope::create(v8::Isolate::GetCurrent()))
+ : m_scope(v8::Isolate::GetCurrent())
{
- m_resolver = ScriptPromiseResolver::create(m_scope->scriptState());
+ m_resolver = ScriptPromiseResolver::create(m_scope.scriptState());
}
virtual ~ScriptPromiseResolverTest()
@@ -75,11 +75,11 @@ public:
isolate()->RunMicrotasks();
}
- v8::Isolate* isolate() { return m_scope->isolate(); }
+ v8::Isolate* isolate() { return m_scope.isolate(); }
protected:
RefPtr<ScriptPromiseResolver> m_resolver;
- OwnPtr<V8TestingScope> m_scope;
+ V8TestingScope m_scope;
};
TEST_F(ScriptPromiseResolverTest, initialState)
« no previous file with comments | « Source/bindings/v8/IDBBindingUtilitiesTest.cpp ('k') | Source/bindings/v8/ScriptPromiseTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698