Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 302893002: Drop ENABLE_NEW_GAMEPAD_API build flag as it is no longer needed (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Drop ENABLE_NEW_GAMEPAD_API build flag as it is no longer needed Drop ENABLE_NEW_GAMEPAD_API build flag as it is no longer needed now that the Blink side has been updated and all the #ifdefs have been removed. R=dmichael@chromium.org, brettw@chromium.org BUG=344556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273921

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M build/common.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Inactive
I don't know why the try bots are red. The patch is applying cleanly for ...
6 years, 6 months ago (2014-05-28 19:41:27 UTC) #1
dmichael (off chromium)
lgtm once the bots are happy. (I'm assuming the blink change and roll has happened) ...
6 years, 6 months ago (2014-05-28 19:54:26 UTC) #2
Inactive
On 2014/05/28 19:54:26, dmichael wrote: > lgtm once the bots are happy. (I'm assuming the ...
6 years, 6 months ago (2014-05-28 19:55:35 UTC) #3
brettw
Thanks for thinking of the GN build.
6 years, 6 months ago (2014-05-28 20:51:28 UTC) #4
Inactive
On 2014/05/28 20:51:28, brettw wrote: > Thanks for thinking of the GN build. brettw@, this ...
6 years, 6 months ago (2014-05-29 00:15:50 UTC) #5
Inactive
On 2014/05/29 00:15:50, Chris Dumez wrote: > On 2014/05/28 20:51:28, brettw wrote: > > Thanks ...
6 years, 6 months ago (2014-05-29 18:56:51 UTC) #6
Inactive
brettw@, ping review?
6 years, 6 months ago (2014-05-30 13:29:15 UTC) #7
brettw
Oh, sorry, I meant to say LGTM before
6 years, 6 months ago (2014-05-30 17:00:22 UTC) #8
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-05-30 17:20:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/302893002/40001
6 years, 6 months ago (2014-05-30 17:23:04 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 18:52:40 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 19:51:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/79425)
6 years, 6 months ago (2014-05-30 19:51:18 UTC) #13
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-05-30 19:52:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/302893002/40001
6 years, 6 months ago (2014-05-30 19:55:44 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:49:26 UTC) #16
Message was sent while issue was closed.
Change committed as 273921

Powered by Google App Engine
This is Rietveld 408576698