Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: ui/app_list/views/app_list_view.h

Issue 302803002: Refactor app list so AppsGridView owns the PaginationModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to review comments (tapted and xiyuan). Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/app_list_view.h
diff --git a/ui/app_list/views/app_list_view.h b/ui/app_list/views/app_list_view.h
index c3effe963206fe00789694ebbeb7ef4cba516d77..0c21175a14d59e28b09db1d4d0fa07ab710e7a7e 100644
--- a/ui/app_list/views/app_list_view.h
+++ b/ui/app_list/views/app_list_view.h
@@ -47,7 +47,6 @@ class APP_LIST_EXPORT AppListView : public views::BubbleDelegateView,
// Initializes the widget and use a given |anchor| plus an |anchor_offset| for
// positioning.
void InitAsBubbleAttachedToAnchor(gfx::NativeView parent,
- PaginationModel* pagination_model,
views::View* anchor,
const gfx::Vector2d& anchor_offset,
views::BubbleBorder::Arrow arrow,
@@ -56,7 +55,6 @@ class APP_LIST_EXPORT AppListView : public views::BubbleDelegateView,
// Initializes the widget and use a fixed |anchor_point_in_screen| for
// positioning.
void InitAsBubbleAtFixedLocation(gfx::NativeView parent,
- PaginationModel* pagination_model,
const gfx::Point& anchor_point_in_screen,
views::BubbleBorder::Arrow arrow,
bool border_accepts_events);
@@ -115,11 +113,13 @@ class APP_LIST_EXPORT AppListView : public views::BubbleDelegateView,
AppListMainView* app_list_main_view() { return app_list_main_view_; }
+ // Gets the PaginationModel owned by this view's apps grid.
+ PaginationModel* GetAppsPaginationModel();
+
private:
friend class ::test::AppListViewTestApi;
void InitAsBubbleInternal(gfx::NativeView parent,
- PaginationModel* pagination_model,
views::BubbleBorder::Arrow arrow,
bool border_accepts_events,
const gfx::Vector2d& anchor_offset);

Powered by Google App Engine
This is Rietveld 408576698