Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: ui/app_list/views/page_switcher.h

Issue 302803002: Refactor app list so AppsGridView owns the PaginationModel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests and bugs. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/views/page_switcher.h
diff --git a/ui/app_list/views/page_switcher.h b/ui/app_list/views/page_switcher.h
index 61a00ae64ce071f4c3cc181591322cce11747352..17213c5d668c41d2c3dbc85416f709334bb810e7 100644
--- a/ui/app_list/views/page_switcher.h
+++ b/ui/app_list/views/page_switcher.h
@@ -33,6 +33,10 @@ class PageSwitcher : public views::View,
// coordinates.
void UpdateUIForDragPoint(const gfx::Point& point);
+ // Disconnects the PageSwitcher from its underlying PaginationModel. Can be
+ // used if the PaginationModel is going to be destroyed.
+ void ReleasePaginationModel();
+
// Overridden from views::View:
virtual gfx::Size GetPreferredSize() const OVERRIDE;
virtual void Layout() OVERRIDE;
@@ -50,7 +54,7 @@ class PageSwitcher : public views::View,
virtual void TransitionStarted() OVERRIDE;
virtual void TransitionChanged() OVERRIDE;
- PaginationModel* model_; // Owned by AppListController.
+ PaginationModel* model_; // Owned by AppListController; may be NULL.
xiyuan 2014/05/30 15:47:47 Update comments as |model_| is ownded by AppsGridV
Matt Giuca 2014/06/02 07:11:23 Done.
views::View* buttons_; // Owned by views hierarchy.
DISALLOW_COPY_AND_ASSIGN(PageSwitcher);

Powered by Google App Engine
This is Rietveld 408576698