Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 302793002: Configure DomDistiller debug output. (Closed)

Created:
6 years, 6 months ago by Yaron
Modified:
6 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, nyquist, kuan
Visibility:
Public.

Description

Configure DomDistiller debug output. Passes the "v" level to DomDistiller for debug output. Now starting chrome with something like: out/Debug/chrome --enable-dom-distiller --vmodule=dom_distiller*=1 will log the boilerpipe debug phases to the console. For content extractor (which doesn't use DomDistillerServiceFactory), adds a --debug-level flag. BUG=375443 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273721

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 3 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Yaron
6 years, 6 months ago (2014-05-27 23:01:28 UTC) #1
Yaron
6 years, 6 months ago (2014-05-27 23:01:37 UTC) #2
Yaron
Since Chris will be out, can you take a look?
6 years, 6 months ago (2014-05-29 01:41:35 UTC) #3
nyquist
lgtm https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode48 components/dom_distiller/standalone/content_extractor.cc:48: const char* kExtractTextOnly = "extract-text-only"; Nit: Totally unrelated, ...
6 years, 6 months ago (2014-05-29 17:50:40 UTC) #4
Yaron
https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode48 components/dom_distiller/standalone/content_extractor.cc:48: const char* kExtractTextOnly = "extract-text-only"; On 2014/05/29 17:50:41, nyquist ...
6 years, 6 months ago (2014-05-29 20:16:30 UTC) #5
Yaron
https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/302793002/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode48 components/dom_distiller/standalone/content_extractor.cc:48: const char* kExtractTextOnly = "extract-text-only"; On 2014/05/29 17:50:41, nyquist ...
6 years, 6 months ago (2014-05-29 20:16:30 UTC) #6
Yaron
6 years, 6 months ago (2014-05-29 20:16:30 UTC) #7
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 6 months ago (2014-05-29 20:16:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/302793002/10001
6 years, 6 months ago (2014-05-29 20:22:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 23:49:26 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 05:23:46 UTC) #11
Message was sent while issue was closed.
Change committed as 273721

Powered by Google App Engine
This is Rietveld 408576698