Issue 302783010: DevTools: Do not use displayNameForURL in NetworkRequest

Issue 302783010: DevTools: Do not use displayNameForURL in NetworkRequest (Closed)

Created:
6 years, 6 months ago by eustas

Modified:
6 years, 6 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

DevTools: Do not use displayNameForURL in NetworkRequest BUG=377723 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174958

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	Source/devtools/front_end/network/NetworkPanel.js	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	Source/devtools/front_end/sdk/NetworkRequest.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm with nits https://codereview.chromium.org/302783010/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/302783010/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode2882 Source/devtools/front_end/network/NetworkPanel.js:2882: if (info.__source === undefined) A more ...

6 years, 6 months ago (2014-05-28 09:27:19 UTC) #2

eustas

https://codereview.chromium.org/302783010/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/302783010/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode2882 Source/devtools/front_end/network/NetworkPanel.js:2882: if (info.__source === undefined) On 2014/05/28 09:27:19, apavlov wrote: ...

6 years, 6 months ago (2014-05-28 09:46:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/302783010/20001

6 years, 6 months ago (2014-05-28 09:47:02 UTC) #5

Message was sent while issue was closed.

Change committed as 174958

Expand Messages | Collapse Messages