Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 302783009: Depend on v8:v8 instead of v8:mksnapshot (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Depend on v8:v8 instead of v8:mksnapshot BUG=none R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-28 07:47:46 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-05-28 15:43:31 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r274198 (tree was closed).
6 years, 6 months ago (2014-06-02 10:13:26 UTC) #3
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-02 10:30:40 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/311433006/ by jochen@chromium.org.

The reason for reverting is: need to revert v8 roll.

Powered by Google App Engine
This is Rietveld 408576698