Issue 302783007: Reuse ZoneList memory if possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302783007: Reuse ZoneList memory if possible. (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer

Modified:
6 years, 6 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reuse ZoneList memory if possible. Clear() is rather wasteful for ZoneLists, because it discards all previously allocated memory, making it impossible to reuse until the whole Zone is released. Better use Rewind(0) in this case, which just resets the length to zero. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21545

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/hydrogen-escape-analysis.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 6 months ago (2014-05-28 08:06:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21545 (presubmit successful).

Expand Messages | Collapse Messages