First version of the PGO recipe.

scripts/slave/recipe_modules/chromium/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import pipes
 
 from slave.recipe_config import config_item_context, ConfigGroup
 from slave.recipe_config import Dict, Single, Static, Set, BadConf
 from slave.recipe_config_types import Path
 
@@ skipping 395 matching lines @@
 
 def _android_common(c):
   gyp_defs = c.gyp_env.GYP_DEFINES
   gyp_defs['fastbuild'] = 1
   gyp_defs['OS'] = c.TARGET_PLATFORM
 
 @config_ctx(includes=['ninja', 'shared_library', 'jsonclang'])
 def codesearch(c):
   gyp_defs = c.gyp_env.GYP_DEFINES
   gyp_defs['fastbuild'] = 1
+
+
+@config_ctx()

[iannucci, 2014/06/19 21:37:17]

you should probably depend on a compiler (ninja), 'default_compiler', and either
'shared_library' or 'static_library'

[Sébastien Marchand, 2014/07/03 19:13:17]

Done.

+def chrome_pgo_base(c):
+  c.gyp_env.GYP_DEFINES['buildtype'] = 'Official'
+  c.gyp_env.GYP_DEFINES['optimize'] = 'max'
+  c.gyp_env.GYP_DEFINES['use_goma'] = 0
+  c.gyp_env.GYP_DEFINES['fastbuild'] = 0

[iannucci, 2014/06/19 21:37:17]

I would set this by doing

fastbuild(c, invert=True)

This has some additional error-checking advantages (for example, if someone
later tried to apply the fastbuild config, it would be an error, instead of just
turning it on).

I see some others have done this wrong already in this file :)

[Sébastien Marchand, 2014/07/03 19:13:17]

Done.

+  c.compile_py.default_targets = ['chrome']
+
+#### 'Full' configurations
+@config_ctx(includes=['chrome_pgo_base'])
+def chrome_pgo_instrument(c):
+  c.gyp_env.GYP_DEFINES['chrome_pgo_phase'] = 1
+
+@config_ctx(includes=['chrome_pgo_base'])
+def chrome_pgo_optimize(c):
+  c.gyp_env.GYP_DEFINES['chrome_pgo_phase'] = 2