Issue 302663003: Fixed an old TODO to use IDS_PPAPI_BROKER_HEADER.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302663003: Fixed an old TODO to use IDS_PPAPI_BROKER_HEADER. (Closed)

Created:
6 years, 6 months ago by Nikhil

Modified:
6 years, 6 months ago

Reviewers:
Bernhard Bauer, Ilya Sherman

CC:
chromium-reviews, dbeam+watch-options_chromium.org, Ilya Sherman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Fixed an old TODO to use IDS_PPAPI_BROKER_HEADER. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273586

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/options/content_settings_handler.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

Ilya Sherman

Hmm, I'm not sure why you chose me as a reviewer for this change, as ...

6 years, 6 months ago (2014-05-28 22:09:52 UTC) #2

Nikhil

On 2014/05/28 22:09:52, Ilya Sherman wrote: > Hmm, I'm not sure why you chose me ...

6 years, 6 months ago (2014-05-29 06:43:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/n.bansal@samsung.com/302663003/1

6 years, 6 months ago (2014-05-29 07:39:16 UTC) #6

Message was sent while issue was closed.

Change committed as 273586