Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 302663002: [Resources] Add new icons for the new avatar button/bubble auth errors. (Closed)

Created:
6 years, 7 months ago by noms (inactive)
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

[Resources] Add new icons for the new avatar button/bubble auth errors. BUG=311235 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272987

Patch Set 1 #

Patch Set 2 : moar better names #

Messages

Total messages: 5 (0 generated)
noms (inactive)
6 years, 7 months ago (2014-05-26 21:14:56 UTC) #1
oshima
error_menu/error_list sounds too generic. Can you come up with better name for these files? (and ...
6 years, 7 months ago (2014-05-27 13:49:13 UTC) #2
noms (inactive)
Done! Please take another look. Thanks.
6 years, 7 months ago (2014-05-27 15:49:29 UTC) #3
oshima
lgtm thanks!
6 years, 7 months ago (2014-05-27 16:02:42 UTC) #4
noms (inactive)
6 years, 7 months ago (2014-05-27 16:57:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r272987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698