build/standalone.gypi - Issue 302653009: Followup comments from https://codereview.chromium.org/298893007/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/standalone.gypi

Issue 302653009: Followup comments from https://codereview.chromium.org/298893007/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/standalone.gypi

diff --git a/build/standalone.gypi b/build/standalone.gypi

index ab8475929bb2555b9ae0ea4834810f9a3fe9c723..3b4f01bef600eacc383d60e615fee32548f37d92 100644

--- a/build/standalone.gypi

+++ b/build/standalone.gypi

@@ -37,6 +37,7 @@

'host_arch%': '<(host_arch)',

'target_arch%': '<(target_arch)',

+ # These two are needed by V8.

'host_arch%': '<(host_arch)',

'target_arch%': '<(target_arch)',

'werror%': '-Werror',

@@ -134,7 +135,7 @@

'defines!': [

'DEBUG',

- 'cflags!': [

+ 'cflags': [

'-Wall',

'-W',

'-Wno-unused-parameter',

« no previous file with comments | « build/gyp_pdfium ('k') | no next file » | no next file with comments »