Chromium Code Reviews| Index: ash/shelf/shelf_view.cc |
| diff --git a/ash/shelf/shelf_view.cc b/ash/shelf/shelf_view.cc |
| index 1cc1cf61203d2e22519615086d8dfb21a5564d52..651cdff0a09e0004c4f9d70a72b4d3db9a261d0f 100644 |
| --- a/ash/shelf/shelf_view.cc |
| +++ b/ash/shelf/shelf_view.cc |
| @@ -454,9 +454,11 @@ void ShelfView::SchedulePaintForAllButtons() { |
| gfx::Rect ShelfView::GetIdealBoundsOfItemIcon(ShelfID id) { |
| int index = model_->ItemIndexByID(id); |
| - if (index == -1 || (index > last_visible_index_ && |
| - index < model_->FirstPanelIndex())) |
| + if (index == -1) |
| return gfx::Rect(); |
| + // Map all items from overflow area to the overflow button. |
| + if (index > last_visible_index_ && index < model_->FirstPanelIndex()) |
|
flackr
2014/05/29 17:05:01
Does this currently work for overflowed panels? Or
Mr4D (OOO till 08-26)
2014/05/29 20:09:51
Yes - and no. Updated comment.
But in the essence
|
| + index = last_visible_index_ + 1; |
| const gfx::Rect& ideal_bounds(view_model_->ideal_bounds(index)); |
| DCHECK_NE(TYPE_APP_LIST, model_->items()[index].type); |
| ShelfButton* button = static_cast<ShelfButton*>(view_model_->view_at(index)); |