tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py - Issue 302653004: Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

Issue 302653004: Cleanup: Remove the remaining instances of ChromiumTestShell from Telemetry scripts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added ChromiumTestShell back to allow buildbots to pass through! Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

index 2fa9fd0ad2e6bd2d9fe08246dd26fa1fb6b73cde..18d9e3df6801bec4aa85f9b95c7d7337df288bba 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py

@@ -24,11 +24,14 @@ CHROME_PACKAGE_NAMES = {

['org.chromium.content_shell_apk',

android_browser_backend.ContentShellBackendSettings,

'ContentShell.apk'],

- # TODO(tonyg): rename android-chromium-testshell to android-chrome-shell

tonyg 2014/06/02 15:20:43 I guess we should keep a TODO here to remove this

'android-chromium-testshell':

['org.chromium.chrome.shell',

android_browser_backend.ChromeShellBackendSettings,

'ChromeShell.apk'],

+ 'android-chrome-shell':

+ ['org.chromium.chrome.shell',

+ android_browser_backend.ChromeShellBackendSettings,

+ 'ChromeShell.apk'],

'android-webview':

['com.android.webview.chromium.shell',

android_browser_backend.WebviewBackendSettings,

« no previous file with comments | « tools/telemetry/docs/telemetry.core.browser_finder.html ('k') | no next file » | no next file with comments »