Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: LayoutTests/fast/svg/resources/whitespace-helper.js

Issue 302643004: [SVG2] Allow leading and trailing whitespace in svg attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@relax_todouble_wtf
Patch Set: split tests to combat slow xp trybots Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/svg/whitespace-angle.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/svg/resources/whitespace-helper.js
diff --git a/LayoutTests/fast/svg/resources/whitespace-helper.js b/LayoutTests/fast/svg/resources/whitespace-helper.js
new file mode 100644
index 0000000000000000000000000000000000000000..61eaf0bbfeacb51b152fe5255962dfad003ae35e
--- /dev/null
+++ b/LayoutTests/fast/svg/resources/whitespace-helper.js
@@ -0,0 +1,92 @@
+/**
+ * Tests attribute parsing and handling of whitespace in attribute values.
+ *
+ * @param type Name of the type being tested (only for test output)
+ * @param target The element that should be tested
+ * @param attribute The name of the attribute that should be tested
+ * @param expected The fallback/default value that is the expectation for invalid values
+ * @param whitespace An array of strings that are valid whitespace characters
+ * @param valid An array of strings containing valid attribute values
+ * @param invalid An array of strings containing invalid attribute values
+ * @param garbage An array of strings containing values that would make a valid value invalid when concatenated
+ * @param assert_valid_custom A function for asserting validity of a valid value, arguments passed to this function: the element and the string from valid values array
+ * @param assert_invalid_custom A function for asserting that an invalid value results in the expected default value, arguments passed to this function: the element and the expected value
+ */
+function testType(type, target, attribute, expected, whitespace, valid, invalid, validunits, garbage, assert_valid_custom, assert_invalid_custom) {
+ whitespace.forEach(function(leading) {
+ whitespace.forEach(function(trailing) {
+ valid.forEach(function(value) {
+ validunits.forEach(function(unit) {
+ var valueStr = leading + value + unit + trailing;
+ var escapedValueStr = valueStr.replace(/(\r)/g, '\\r').replace(/(\n)/g, '\\n').replace(/(\t)/g, '\\t').replace(/(\f)/g, '\\f');
+ test(function() {
+ try {
+ target.setAttribute(attribute, valueStr);
+ assert_equals(target.getAttribute(attribute), valueStr);
+ assert_valid_custom(target, value);
+ }
+ finally {
+ target.removeAttribute(attribute);
+ }
+ }, "Test " + type + " valid value: " + escapedValueStr );
+ });
+ });
+
+ // test invalid values
+ invalid.forEach(function(value) {
+ validunits.forEach(function(unit) {
+ var valueStr = leading + value + unit + trailing;
+ var escapedValueStr = valueStr.replace(/(\r)/g, '\\r').replace(/(\n)/g, '\\n').replace(/(\t)/g, '\\t').replace(/(\f)/g, '\\f');
+ test(function() {
+ try {
+ target.setAttribute(attribute, valueStr);
+ assert_equals(target.getAttribute(attribute), valueStr);
+ assert_invalid_custom(target, expected);
+ }
+ finally {
+ target.removeAttribute(attribute);
+ }
+ }, "Test " + type + " invalid value: " + escapedValueStr);
+ });
+ });
+ });
+
+ // test whitespace between value and unit
+ validunits.forEach(function(unit) {
+ if (unit == "" || leading == "")
+ return;
+ valid.forEach(function(value) {
+ var valueStr = value + leading + unit;
+ var escapedValueStr = valueStr.replace(/(\r)/g, '\\r').replace(/(\n)/g, '\\n').replace(/(\t)/g, '\\t').replace(/(\f)/g, '\\f');
+ test(function() {
+ try {
+ target.setAttribute(attribute, valueStr);
+ assert_equals(target.getAttribute(attribute), valueStr);
+ assert_invalid_custom(target, expected);
+ }
+ finally {
+ target.removeAttribute(attribute);
+ }
+ }, "Test " + type + " WS invalid value: " + escapedValueStr);
+ });
+ });
+
+ // test trailing garbage
+ garbage.forEach(function(trailing) {
+ valid.forEach(function(value) {
+ var valueStr = leading + value + trailing;
+ var escapedValueStr = valueStr.replace(/(\r)/g, '\\r').replace(/(\n)/g, '\\n').replace(/(\t)/g, '\\t').replace(/(\f)/g, '\\f');
+ test(function() {
+ try {
+ target.setAttribute(attribute, valueStr);
+ assert_equals(target.getAttribute(attribute), valueStr);
+ assert_invalid_custom(target, expected);
+ }
+ finally {
+ target.removeAttribute(attribute);
+ }
+ }, "Test " + type + " trailing garbage, value: " + escapedValueStr);
+ });
+ });
+ });
+}
« no previous file with comments | « no previous file | LayoutTests/fast/svg/whitespace-angle.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698