Source/core/svg/SVGRect.cpp - Issue 302643004: [SVG2] Allow leading and trailing whitespace in svg attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGRect.cpp

Issue 302643004: [SVG2] Allow leading and trailing whitespace in svg attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@relax_todouble_wtf

Patch Set: split tests to combat slow xp trybots Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGRect.cpp

diff --git a/Source/core/svg/SVGRect.cpp b/Source/core/svg/SVGRect.cpp

index 6dcca91788ffd0e42f450efc3bfac459b473113f..4869e222bfcd9ee49a524b5d8e8dce6962782f5e 100644

--- a/Source/core/svg/SVGRect.cpp

+++ b/Source/core/svg/SVGRect.cpp

@@ -74,7 +74,7 @@ void SVGRect::parse(const CharType*& ptr, const CharType* end, ExceptionState& e

float y = 0.0f;

float width = 0.0f;

float height = 0.0f;

- bool valid = parseNumber(ptr, end, x) && parseNumber(ptr, end, y) && parseNumber(ptr, end, width) && parseNumber(ptr, end, height, false);

+ bool valid = parseNumber(ptr, end, x) && parseNumber(ptr, end, y) && parseNumber(ptr, end, width) && parseNumber(ptr, end, height, DisallowWhitespace);

if (!valid) {

exceptionState.throwDOMException(SyntaxError, "Problem parsing rect \"" + String(start, end - start) + "\"");

« no previous file with comments | « Source/core/svg/SVGPointList.cpp ('k') | Source/core/svg/SVGStringList.cpp » ('j') | no next file with comments »