[SVG2] Allow leading and trailing whitespace in svg attributes

Source/core/svg/SVGAngle.cpp

 /*
  * Copyright (C) 2004, 2005, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 139 matching lines @@
 {
     // If there's no unit given, the angle type is unspecified.
     if (ptr == end)
         return SVGAngle::SVG_ANGLETYPE_UNSPECIFIED;
 
     const CharType firstChar = *ptr;
 
     // If the unit contains only one character, the angle type is unknown.
     ++ptr;
     if (ptr == end)
-        return SVGAngle::SVG_ANGLETYPE_UNKNOWN;
+        return isSVGSpace(firstChar) ? SVGAngle::SVG_ANGLETYPE_UNSPECIFIED : SVGAngle::SVG_ANGLETYPE_UNKNOWN;
 
     const CharType secondChar = *ptr;
 
     // If the unit contains only two characters, the angle type is unknown.
     ++ptr;
     if (ptr == end)
-        return SVGAngle::SVG_ANGLETYPE_UNKNOWN;
+        return isSVGSpace(firstChar) && isSVGSpace(secondChar) ? SVGAngle::SVG_ANGLETYPE_UNSPECIFIED : SVGAngle::SVG_ANGLETYPE_UNKNOWN;
 
     const CharType thirdChar = *ptr;
     if (firstChar == 'd' && secondChar == 'e' && thirdChar == 'g')
         return SVGAngle::SVG_ANGLETYPE_DEG;
     if (firstChar == 'r' && secondChar == 'a' && thirdChar == 'd')
         return SVGAngle::SVG_ANGLETYPE_RAD;
 
     // If the unit contains three characters, but is not deg or rad, then it's unknown.

[pdr., 2014/06/02 14:35:19]

Can you update these comments to say something like:
"If the unit contains all spaces, it's unspecified. If the unit contains three
characters but is not deg or rad, it's unknown.

This is sort of a "what" comment and not a "why" one but I think it would make
the logic here easier to reason about.

[Erik Dahlström (inactive), 2014/06/04 16:25:43]

I went with a rewrite to hopefully make it more clear.

     ++ptr;
     if (ptr == end)
-        return SVGAngle::SVG_ANGLETYPE_UNKNOWN;
+        return isSVGSpace(firstChar) && isSVGSpace(secondChar) && isSVGSpace(thirdChar) ? SVGAngle::SVG_ANGLETYPE_UNSPECIFIED : SVGAngle::SVG_ANGLETYPE_UNKNOWN;
 
     const CharType fourthChar = *ptr;
 
     if (firstChar == 'g' && secondChar == 'r' && thirdChar == 'a' && fourthChar == 'd')
         return SVGAngle::SVG_ANGLETYPE_GRAD;
+    if (firstChar == 't' && secondChar == 'u' && thirdChar == 'r' && fourthChar == 'n')
+        return SVGAngle::SVG_ANGLETYPE_TURN;
+
+    if (isSVGSpace(firstChar)
+        && isSVGSpace(secondChar)
+        && isSVGSpace(thirdChar)
+        && isSVGSpace(fourthChar)) {
+        skipOptionalSVGSpaces(++ptr, end);
+        if (ptr == end)
+            return SVGAngle::SVG_ANGLETYPE_UNSPECIFIED;
+    }
 
     return SVGAngle::SVG_ANGLETYPE_UNKNOWN;
 }
 
 String SVGAngle::valueAsString() const
 {
     switch (m_unitType) {
     case SVG_ANGLETYPE_DEG: {
         DEFINE_STATIC_LOCAL(String, degString, ("deg"));
         return String::number(m_valueInSpecifiedUnits) + degString;
@@ skipping 14 matching lines @@
     ASSERT_NOT_REACHED();
     return String();
 }
 
 template<typename CharType>
 static bool parseValue(const String& value, float& valueInSpecifiedUnits, SVGAngle::SVGAngleType& unitType)
 {
     const CharType* ptr = value.getCharacters<CharType>();
     const CharType* end = ptr + value.length();
 
-    if (!parseNumber(ptr, end, valueInSpecifiedUnits, false))
+    if (!parseNumber(ptr, end, valueInSpecifiedUnits, ALLOW_LEADING))
         return false;
 
     unitType = stringToAngleType(ptr, end);
     if (unitType == SVGAngle::SVG_ANGLETYPE_UNKNOWN)
         return false;
 
     return true;
 }
 
 void SVGAngle::setValueAsString(const String& value, ExceptionState& exceptionState)
@@ skipping 168 matching lines @@
 
 void SVGAngle::orientTypeChanged()
 {
     if (orientType()->enumValue() == SVGMarkerOrientAuto) {
         m_unitType = SVG_ANGLETYPE_UNSPECIFIED;
         m_valueInSpecifiedUnits = 0;
     }
 }
 
 }