Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 302643002: Remove zoom special casing of SVG when computing border-widths (Closed)

Created:
6 years, 7 months ago by davve
Modified:
6 years, 6 months ago
Reviewers:
pdr., dglazkov, fs
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove zoom special casing of SVG when computing border-widths Ever since border-image-width was implemented in https://bugs.webkit.org/show_bug.cgi?id=67657 border-widths values haven't been scaled with the zoom level for SVG elements. Remove the special casing since it doesn't seems to be any good reason for having it. Firefox doesn't do anything of the sort and there is no specification support for it. BUG=377447 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174960

Patch Set 1 #

Patch Set 2 : Remove method on CSSToStyleMap rendered unnecessary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
A LayoutTests/fast/css/border-image-widths-on-svg-with-zoom.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/border-image-widths-on-svg-with-zoom-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/CSSToStyleMap.cpp View 1 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
davve
Found this one when trying to understand how useSVGZoomRules() works (and if we can remove ...
6 years, 7 months ago (2014-05-26 13:56:42 UTC) #1
davve
Looping in some more reviewers that might have opinions here.
6 years, 7 months ago (2014-05-27 15:25:20 UTC) #2
davve
Also, see https://codereview.chromium.org/300553009 where I experiment with removing more of useSVGZoomRules(). Not done with that ...
6 years, 7 months ago (2014-05-27 15:57:46 UTC) #3
pdr.
On 2014/05/27 15:57:46, David Vest wrote: > Also, see https://codereview.chromium.org/300553009 where I experiment with > ...
6 years, 7 months ago (2014-05-27 17:34:21 UTC) #4
davve
The CQ bit was checked by davve@opera.com
6 years, 6 months ago (2014-05-28 11:32:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/302643002/20001
6 years, 6 months ago (2014-05-28 11:33:26 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 11:50:52 UTC) #7
Message was sent while issue was closed.
Change committed as 174960

Powered by Google App Engine
This is Rietveld 408576698