Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 302633012: Remove --enable-webrtc-tcp-server-socket (Closed)

Created:
6 years, 6 months ago by Alpha Left Google
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Remove --enable-webrtc-tcp-server-socket This switch is not used. Remove it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Alpha Left Google
6 years, 6 months ago (2014-05-28 20:15:32 UTC) #1
Alpha Left Google
Ping reviewers.
6 years, 6 months ago (2014-05-29 20:49:55 UTC) #2
Ronghua Wu (Left Chromium)
Looks like wuchengli is the one add the switch. May want to check with him ...
6 years, 6 months ago (2014-05-29 22:05:32 UTC) #3
Alpha Left Google
On 2014/05/29 22:05:32, Ronghua Wu wrote: > Looks like wuchengli is the one add the ...
6 years, 6 months ago (2014-05-29 22:06:22 UTC) #4
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-05-29 22:06:25 UTC) #5
Alpha Left Google
The CQ bit was unchecked by hclam@chromium.org
6 years, 6 months ago (2014-05-29 22:06:29 UTC) #6
Alpha Left Google
+jam for content/public
6 years, 6 months ago (2014-05-29 22:07:20 UTC) #7
Ronghua Wu (Left Chromium)
Oh, ok. I said that because that's what I got from svn blame. But I ...
6 years, 6 months ago (2014-05-29 22:08:14 UTC) #8
jam
lgtm
6 years, 6 months ago (2014-05-30 01:49:20 UTC) #9
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-05-30 01:52:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/302633012/1
6 years, 6 months ago (2014-05-30 01:54:36 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:33:39 UTC) #12
Message was sent while issue was closed.
Change committed as 273790

Powered by Google App Engine
This is Rietveld 408576698