Issue 302633009: Add example to MessageLoop::ReleaseSoon comment.

Issue 302633009: Add example to MessageLoop::ReleaseSoon comment. (Closed)

Created:
6 years, 7 months ago by maniscalco

Modified:
6 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add example to MessageLoop::ReleaseSoon comment. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273059

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	base/message_loop/message_loop.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 10 (0 generated)

maniscalco

Hi Mark, would you please review this change? The other day, I (mis)used ReleaseSoon so ...

6 years, 7 months ago (2014-05-27 17:59:12 UTC) #1

maniscalco

On 2014/05/27 18:03:35, Mark Mentovai wrote: > LGTM Thanks for the speedy review!

6 years, 7 months ago (2014-05-27 18:11:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/302633009/1

6 years, 7 months ago (2014-05-27 18:13:47 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/302633009/1

6 years, 7 months ago (2014-05-27 20:16:21 UTC) #8

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...

6 years, 7 months ago (2014-05-27 21:45:19 UTC) #9

Message was sent while issue was closed.

Change committed as 273059