Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 302633006: Fix host gcc version detection for android webview. (Closed)

Created:
6 years, 7 months ago by Torne
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix host gcc version detection for android webview. Android WebView builds use a hermetic host toolchain, so detecting the host gcc version with compiler_version doesn't work. Hardcode the current versions used instead. BUG=377684 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/common.gypi View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Torne
6 years, 7 months ago (2014-05-27 11:18:46 UTC) #1
mkosiba (inactive)
lgtm
6 years, 7 months ago (2014-05-27 11:34:56 UTC) #2
Torne
Nico, if you test this and it works feel free to just tick commit if ...
6 years, 7 months ago (2014-05-27 12:39:00 UTC) #3
Nico
lgtm (untested, but looks right… :-P) If you talk to the aosp build folks at ...
6 years, 7 months ago (2014-05-27 12:55:56 UTC) #4
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 7 months ago (2014-05-27 12:56:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/302633006/1
6 years, 7 months ago (2014-05-27 12:56:30 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 13:59:06 UTC) #7
Message was sent while issue was closed.
Change committed as 272965

Powered by Google App Engine
This is Rietveld 408576698