binary_size: Check debug data format before starting.

binary_size: Check debug data format before starting.

If the debug data format is DWARF4 and binutils is not new enough
the output will be more or less useless (no files will be detected).
Detect that case early instead of having the user wait for many hours
for something that can't be used.

BUG=370378
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275866

[Primiano Tucci (use gerrit), 2014-05-27 09:40:10]

Just some python drive-by nits by me, Andrew is the binary expert here.

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
File tools/binary_size/run_binary_size_analysis.py (right):

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:548: """There are two common
versions of the DWARF debug formats and
Nit: docstring format (1 line + blank line + description)

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:553: version_re =
re.compile(r"^GNU [^ ]+ .* (\d+).(\d+).*?$", re.M)
Please be consistent with quotes (double vs single)

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:569: print("""\
From code style:

Yes:
  print ("This is much nicer.\n"
         "Do it this way.\n")
  No:
    print """This is pretty ugly.
Don't do this.
"""

[Andrew Hayden (chromium.org), 2014-05-27 11:26:44]

This is totally rad! One question, though: I don't know what the format of the
executable ends up being on Windows. I assume it is Portable Executable (PE);
we're not at the point yet where the tool has been run on Windows, but I'd like
to get there.

We should gate this logic on the OS. Linux, yes. Android, it looks to me like
it's DWARF2. Mac? Windows? I don't know.

[Daniel Bratell, 2014-06-04 13:16:52]

On 2014/05/27 11:26:44, Andrew Hayden wrote:
> This is totally rad! One question, though: I don't know what the format of the
> executable ends up being on Windows. I assume it is Portable Executable (PE);
> we're not at the point yet where the tool has been run on Windows, but I'd
like
> to get there.
> 
> We should gate this logic on the OS. Linux, yes. Android, it looks to me like
> it's DWARF2. Mac? Windows? I don't know.

I also have no idea about Windows. I would like to try to get it working on
Windows but I think it will require quite a lot of work. Potentially it could
give better output though, since Microsoft has historically been good at debug
information. There is not (as far as I know) any clones of nm and addr2line
though.

But different project.

[Daniel Bratell, 2014-06-04 13:31:02]

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
File tools/binary_size/run_binary_size_analysis.py (right):

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:548: """There are two common
versions of the DWARF debug formats and
On 2014/05/27 09:40:10, Primiano Tucci wrote:
> Nit: docstring format (1 line + blank line + description)

Done.

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:553: version_re =
re.compile(r"^GNU [^ ]+ .* (\d+).(\d+).*?$", re.M)
On 2014/05/27 09:40:10, Primiano Tucci wrote:
> Please be consistent with quotes (double vs single)

Done.

https://codereview.chromium.org/302633003/diff/1/tools/binary_size/run_binary...
tools/binary_size/run_binary_size_analysis.py:569: print("""\
On 2014/05/27 09:40:10, Primiano Tucci wrote:
> From code style:
> 
> Yes:
>   print ("This is much nicer.\n"
>          "Do it this way.\n")
>   No:
>     print """This is pretty ugly.
> Don't do this.
> """

Will fix, but the suggested format is really bad if the indentation plus the
string length would exceed ~70 characters. In another program I've tried both
and I found that for larger blocks of output, the """ format worked better.
Especially if the first line is """\ so that all lines are indented equally.

[Daniel Bratell, 2014-06-05 13:38:43]

Can you please take a look at the new patch.

[Andrew Hayden (chromium.org), 2014-06-05 15:28:28]

LGTM

[Daniel Bratell, 2014-06-09 12:33:40]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-06-09 12:34:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/302633003/20001

[commit-bot: I haz the power, 2014-06-09 20:36:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-09 22:48:24]

Change committed as 275866