Issue 302623002: ServiceWorker: Add check for id overlap between pushed and deleted resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 302623002: ServiceWorker: Add check for id overlap between pushed and deleted resources (Closed)

Created:
6 years, 7 months ago by nhiroki

Modified:
6 years, 7 months ago

Reviewers:
michaeln, serviceworker-reviews, dominicc (has gone to gerrit)

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ServiceWorker: Add check for id overlap between pushed and deleted resources Currently resource sharing across versions and registrations is not supported, so resource ids should not be overlapped between a new registration and an old registration on WriteRegistration(). This change adds a check to make sure it. BUG=n/a TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272912