Source/platform/scroll/Scrollbar.cpp - Issue 302603009: Fix scrollbar thumb drag cancellation in RTL mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/scroll/Scrollbar.cpp

Issue 302603009: Fix scrollbar thumb drag cancellation in RTL mode (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Mac's scrollbar behavior is different from Aura Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/scroll/Scrollbar.cpp

diff --git a/Source/platform/scroll/Scrollbar.cpp b/Source/platform/scroll/Scrollbar.cpp

index dc6946730fb27bc0e530262abbf8f4b5a489b2ef..712d5c131b9540ea383a7c6de3ddeebf793842bb 100644

--- a/Source/platform/scroll/Scrollbar.cpp

+++ b/Source/platform/scroll/Scrollbar.cpp

@@ -392,7 +392,7 @@ void Scrollbar::mouseMoved(const PlatformMouseEvent& evt)

if (m_pressedPart == ThumbPart) {

if (theme()->shouldSnapBackToDragOrigin(this, evt)) {

if (m_scrollableArea)

- m_scrollableArea->scrollToOffsetWithoutAnimation(m_orientation, m_dragOrigin);

+ m_scrollableArea->scrollToOffsetWithoutAnimation(m_orientation, m_dragOrigin + m_scrollableArea->minimumScrollPosition(m_orientation));

} else {

moveThumb(m_orientation == HorizontalScrollbar ?

convertFromContainingWindow(evt.position()).x() :