Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 302603009: Fix scrollbar thumb drag cancellation in RTL mode (Closed)

Created:
6 years, 7 months ago by trchen
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix scrollbar thumb drag cancellation in RTL mode Scrollbar stores original scroll position in non-negative scroll coordinates. When sending those coordinates to ScrollableArea, they should be offsetted with minimumScrollPosition() first. R=jchaffraix@chromium.org BUG=377131 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175100

Patch Set 1 #

Patch Set 2 : Mac's scrollbar behavior is different from Aura #

Total comments: 1

Patch Set 3 : add test comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -1 line) Patch
A LayoutTests/fast/overflow/rtl-scrollbar-drag-origin.html View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/fast/overflow/rtl-scrollbar-drag-origin-expected.txt View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
trchen
This is a simple one-line fix. PTAL, thanks!
6 years, 7 months ago (2014-05-28 00:34:33 UTC) #1
trchen
Ping?
6 years, 6 months ago (2014-05-28 23:30:55 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/302603009/diff/20001/LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt File LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt (right): https://codereview.chromium.org/302603009/diff/20001/LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt#newcode2 LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt:2: FAIL container.scrollLeft should be 350. Was 0. I ...
6 years, 6 months ago (2014-05-29 18:15:49 UTC) #3
trchen
On 2014/05/29 18:15:49, Julien Chaffraix - PST wrote: > lgtm > > https://codereview.chromium.org/302603009/diff/20001/LayoutTests/platform/mac/fast/overflow/rtl-scrollbar-drag-origin-expected.txt > File ...
6 years, 6 months ago (2014-05-29 20:53:26 UTC) #4
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 6 months ago (2014-05-29 21:10:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/302603009/30001
6 years, 6 months ago (2014-05-29 21:10:50 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 03:25:49 UTC) #7
Message was sent while issue was closed.
Change committed as 175100

Powered by Google App Engine
This is Rietveld 408576698