Regression(r174876): Use OILPAN empty destructor macros

Regression(r174876): Use OILPAN empty destructor macros

Use OILPAN empty destructor macros as OILPAN is complaining about having a user
defined destructor. The destructor used to be protected by #if !OILPAN but I
removed this in r174876 inadvertently.

TBR=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174901

[sof, 2014-05-27 18:49:34]

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientationController.cpp (right):

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientationController.cpp:19: #if
!ENABLE(OILPAN)
DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController) (no ; at
the end.)

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientationController.h (right):

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientationController.h:18: #if
!ENABLE(OILPAN)
Use
DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController)
instead (and put it above public:, for consistency.)

[Inactive, 2014-05-27 18:51:04]

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientationController.cpp (right):

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientationController.cpp:19: #if
!ENABLE(OILPAN)
On 2014/05/27 18:49:35, sof wrote:
> DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController) (no ; at
> the end.)

Is it OK to simply remove the destructor like I did in my second patch set?

[Inactive, 2014-05-27 19:08:22]

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientationController.cpp (right):

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientationController.cpp:19: #if
!ENABLE(OILPAN)
On 2014/05/27 18:49:35, sof wrote:
> DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController) (no ; at
> the end.)

Done.

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
File Source/modules/screen_orientation/ScreenOrientationController.h (right):

https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
Source/modules/screen_orientation/ScreenOrientationController.h:18: #if
!ENABLE(OILPAN)
On 2014/05/27 18:49:35, sof wrote:
> Use
> DECLARE_EMPTY_VIRTUAL_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController)
> instead (and put it above public:, for consistency.)

Done.

[Inactive, 2014-05-27 19:09:12]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-27 19:09:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/302603005/30001

[sof, 2014-05-27 21:44:15]

On 2014/05/27 18:51:04, Chris Dumez wrote:
>
https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
> File Source/modules/screen_orientation/ScreenOrientationController.cpp
(right):
> 
>
https://codereview.chromium.org/302603005/diff/1/Source/modules/screen_orient...
> Source/modules/screen_orientation/ScreenOrientationController.cpp:19: #if
> !ENABLE(OILPAN)
> On 2014/05/27 18:49:35, sof wrote:
> > DEFINE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(ScreenOrientationController) (no ;
at
> > the end.)
> 
> Is it OK to simply remove the destructor like I did in my second patch set?

Good question. For this class, I think it is just fine to have the compiler
synthesize an inlined version instead. But the general local preference seems to
be to declare derived destructors and define them out-of-line (.cpp), so as to
get a handle on the amount of code that's inlined.

[commit-bot: I haz the power, 2014-05-27 22:04:52]

Change committed as 174901

[haraken, 2014-05-27 22:48:51]

LGTM