Plumb GpuMemoryBuffer allocation to GPU process.

content/common/gpu/client/gpu_channel_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_CLIENT_GPU_CHANNEL_HOST_H_
 #define CONTENT_COMMON_GPU_CLIENT_GPU_CHANNEL_HOST_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 66 matching lines @@
       int32 image_id,
       const CreateImageCallback& callback) = 0;
   virtual void DeleteImage(int32 image_id, int32 sync_point) = 0;
   virtual scoped_ptr<gfx::GpuMemoryBuffer> AllocateGpuMemoryBuffer(
       size_t width,
       size_t height,
       unsigned internalformat,
       unsigned usage) = 0;
 };
 
+class CONTENT_EXPORT GpuChannelHostGpuBufferFactory {

[reveman, 2014/06/02 22:47:33]

We need a better name for this and I think it's probably best that we move it to
a separate file. We want to make it as easy as possible to move everything but
the implementation of this interface out of content/ in the future.

How about GpuMemoryBufferFactoryHost?

+ public:
+  typedef base::Callback<void(const gfx::GpuMemoryBufferHandle& handle)>
+      CreateGpuMemoryBufferCallback;
+
+  virtual ~GpuChannelHostGpuBufferFactory() {}

[reveman, 2014/06/02 22:47:33]

The dtor doesn't have to be part of the interface. Please make this protected as
that prevents the client from being able to delete it and removes the need for
CONTENT_EXPORT above.

+
+  virtual void CreateGpuMemoryBuffer(
+      size_t width,
+      size_t height,
+      unsigned internalformat,
+      unsigned usage,
+      const gfx::GpuMemoryBufferHandle& handle,

[reveman, 2014/06/02 22:47:33]

nit: maybe have the handle be first parameter. it's in some sense the most
important.

+      const CreateGpuMemoryBufferCallback& callback) = 0;
+  virtual void DeleteGpuMemoryBuffer(const gfx::GpuMemoryBufferHandle& handle,

[reveman, 2014/06/02 22:47:33]

Hm, should this be "Delete" or "Destroy"? Not sure why I chose Delete in case of
Create/DeleteImage but I feel like that was a mistake. Create/Destroy seem more
appropriate.

+                                     int32 sync_point) = 0;
+};
+
 // Encapsulates an IPC channel between the client and one GPU process.
 // On the GPU process side there's a corresponding GpuChannel.
 // Every method can be called on any thread with a message loop, except for the
 // IO thread.
 class GpuChannelHost : public IPC::Sender,
                        public base::RefCountedThreadSafe<GpuChannelHost> {
  public:
   // Must be called on the main thread (as defined by the factory).
   static scoped_refptr<GpuChannelHost> Create(
       GpuChannelHostFactory* factory,
@@ skipping 147 matching lines @@
   // Used to look up a proxy from its routing id.
   typedef base::hash_map<int, CommandBufferProxyImpl*> ProxyMap;
   ProxyMap proxies_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuChannelHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_GPU_CLIENT_GPU_CHANNEL_HOST_H_