Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 302603002: Fix mem leaks in tests. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix mem leaks in tests & ScriptCompiler::CompileUnbound. - Leak in test-parsing/DontRegressPreParserDataSizes - Leak in test-api/EventLogging - Leak in ScriptCompiler::CompileUnbound which won't happen during normal operation, but exposed by test-api/CompiledWithInvalidCachedData. R=yangguo@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M src/api.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
yangguo, ptal
6 years, 7 months ago (2014-05-26 07:47:02 UTC) #1
Yang
On 2014/05/26 07:47:02, marja wrote: > yangguo, ptal lgtm.
6 years, 7 months ago (2014-05-26 07:55:43 UTC) #2
marja
6 years, 7 months ago (2014-05-26 11:06:31 UTC) #3
Committed as revision 21488, but the script was terminated before it update this
commit.

Powered by Google App Engine
This is Rietveld 408576698