Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
302573003:
Remove ProtocolFactory use from appcache_request_handler_unittest (Closed)
|
Created:
6 years, 7 months ago by cbentzel Modified:
6 years, 6 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionRemove ProtocolFactory use from appcache_request_handler_unittest
This is being done to remove use of a deprecated API in net/
BUG=81979
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274079
Patch Set 1 #Patch Set 2 : Fix all unit tests #
Total comments: 2
Patch Set 3 : Clear out job_ on IO thread #Patch Set 4 : Rebase #
Total comments: 1
Patch Set 5 : Ordering #Messages
Total messages: 24 (0 generated)
lgtm
lgtm2
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/302573003/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
On 2014/05/28 13:26:44, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > win_chromium_x64_rel on tryserver.chromium > (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) Looks like real issues with the tests exposed on the win_rel bots
https://codereview.chromium.org/302573003/diff/20001/content/browser/appcache... File content/browser/appcache/appcache_request_handler_unittest.cc (left): https://codereview.chromium.org/302573003/diff/20001/content/browser/appcache... content/browser/appcache/appcache_request_handler_unittest.cc:221: job_ = NULL; ooops, job_ = NULL should not be deleted here
https://codereview.chromium.org/302573003/diff/20001/content/browser/appcache... File content/browser/appcache/appcache_request_handler_unittest.cc (left): https://codereview.chromium.org/302573003/diff/20001/content/browser/appcache... content/browser/appcache/appcache_request_handler_unittest.cc:221: job_ = NULL; On 2014/05/28 20:19:19, michaeln wrote: > ooops, job_ = NULL should not be deleted here That was old code.
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/302573003/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
https://codereview.chromium.org/302573003/diff/60001/content/browser/appcache... File content/browser/appcache/appcache_request_handler_unittest.cc (right): https://codereview.chromium.org/302573003/diff/60001/content/browser/appcache... content/browser/appcache/appcache_request_handler_unittest.cc:238: job_ = NULL; looks like the destruction order matters
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/302573003/70001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
The CQ bit was unchecked by cbentzel@chromium.org
The CQ bit was checked by cbentzel@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/302573003/70001
Message was sent while issue was closed.
Change committed as 274079 |
