Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: content/renderer/web_ui_mojo.h

Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-shell
Patch Set: address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/mojo/service_registry_js_wrapper.cc ('k') | content/renderer/web_ui_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/web_ui_mojo.h
diff --git a/content/renderer/web_ui_mojo.h b/content/renderer/web_ui_mojo.h
index 2a645429a2f3500c2e07c886debc70db243780fd..0b0c99cd84ba17cf2180611d7dd85c26621296c3 100644
--- a/content/renderer/web_ui_mojo.h
+++ b/content/renderer/web_ui_mojo.h
@@ -30,9 +30,6 @@ class WebUIMojo
public:
explicit WebUIMojo(RenderView* render_view);
- // Sets the handle to the current WebUI.
- void SetBrowserHandle(mojo::ScopedMessagePipeHandle handle);
-
private:
class MainFrameObserver : public RenderFrameObserver {
public:
@@ -55,13 +52,10 @@ class WebUIMojo
void CreateContextState();
void DestroyContextState(v8::Handle<v8::Context> context);
- // Invoked when the frame finishes loading. Invokes SetHandleOnContextState()
- // if necessary.
+ // Invoked when the frame finishes loading. Invokes Run() on the
+ // WebUIMojoContextState.
void OnDidFinishDocumentLoad();
- // Invokes SetHandle() on the WebUIMojoContextState (if there is one).
- void SetHandleOnContextState(mojo::ScopedMessagePipeHandle handle);
-
WebUIMojoContextState* GetContextState();
// RenderViewObserver overrides:
@@ -69,16 +63,6 @@ class WebUIMojo
MainFrameObserver main_frame_observer_;
- // Set to true in DidFinishDocumentLoad(). 'main' is only executed once this
- // happens.
- bool did_finish_document_load_;
-
- // If SetBrowserHandle() is invoked before the document finishes loading the
- // MessagePipeHandle is stored here. When the document finishes loading
- // SetHandleOnContextState() is invoked to send the handle to the
- // WebUIMojoContextState and ultimately the page.
- mojo::ScopedMessagePipeHandle pending_handle_;
-
DISALLOW_COPY_AND_ASSIGN(WebUIMojo);
};
« no previous file with comments | « content/renderer/mojo/service_registry_js_wrapper.cc ('k') | content/renderer/web_ui_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698