Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: content/public/common/service_registry.h

Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-shell
Patch Set: address comment Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/service_registry.h
diff --git a/content/public/common/service_registry.h b/content/public/common/service_registry.h
index f35bad4c1b23029075a77a3d19f21a245d196895..64ec5bd5e2cbb8c7148baea9241d31054a5ce99f 100644
--- a/content/public/common/service_registry.h
+++ b/content/public/common/service_registry.h
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
#include "base/strings/string_piece.h"
#include "content/common/content_export.h"
#include "mojo/public/cpp/bindings/interface_ptr.h"
@@ -58,6 +59,8 @@ class CONTENT_EXPORT ServiceRegistry {
virtual void GetRemoteInterface(const base::StringPiece& name,
mojo::ScopedMessagePipeHandle handle) = 0;
+ virtual base::WeakPtr<ServiceRegistry> GetWeakPtr() = 0;
darin (slow to review) 2014/06/28 21:10:38 hmm, it seems a bit uncommon to expose a WeakPtr t
Sam McNally 2014/06/30 01:26:14 Removed it.
+
private:
template <typename Interface>
static void ForwardToServiceFactory(

Powered by Google App Engine
This is Rietveld 408576698