chrome/browser/ui/webui/omnibox/omnibox_ui.cc - Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/omnibox/omnibox_ui.cc

Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-shell

Patch Set: address comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/omnibox/omnibox_ui.h ('k') | content/browser/webui/web_ui_mojo_browsertest.cc » ('j') | content/browser/webui/web_ui_mojo_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/omnibox/omnibox_ui.cc

diff --git a/chrome/browser/ui/webui/omnibox/omnibox_ui.cc b/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

index 2ff94ac37f16f8939cd73122f5e6c8c4b4880516..b9fa2a922e212fb59bca6dd431f1dd4707deea70 100644

--- a/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

+++ b/chrome/browser/ui/webui/omnibox/omnibox_ui.cc

@@ -29,8 +29,7 @@ OmniboxUI::OmniboxUI(content::WebUI* web_ui) : MojoWebUIController(web_ui) {

OmniboxUI::~OmniboxUI() {}

scoped_ptr<MojoWebUIHandler> OmniboxUI::CreateUIHandler(

- mojo::ScopedMessagePipeHandle handle_to_page) {

- return scoped_ptr<MojoWebUIHandler>(

- mojo::BindToPipe(new OmniboxUIHandler(Profile::FromWebUI(web_ui())),

- handle_to_page.Pass()));

+ mojo::InterfaceRequest<OmniboxUIHandlerMojo> request) {

+ return scoped_ptr<MojoWebUIHandler>(mojo::BindToRequest(

+ new OmniboxUIHandler(Profile::FromWebUI(web_ui())), &request));

}