Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: content/test/data/web_ui_mojo.js

Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-shell
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/data/web_ui_mojo.js
diff --git a/content/test/data/web_ui_mojo.js b/content/test/data/web_ui_mojo.js
index 086dc0041252bc901e67f7708a6d92436c7324b8..ab24f5ca76f96c456c1a7c025f196483ab2b55e3 100644
--- a/content/test/data/web_ui_mojo.js
+++ b/content/test/data/web_ui_mojo.js
@@ -5,7 +5,8 @@
define('main', [
'mojo/public/js/bindings/connection',
'content/test/data/web_ui_test_mojo_bindings.mojom',
-], function (connection, bindings) {
+ 'content/public/renderer/service_registry',
+], function (connection, bindings, serviceRegistry) {
var retainedConnection;
function RendererTargetTest(bindings) {
@@ -23,8 +24,10 @@ define('main', [
this.bindings_.pingResponse();
};
- return function(handle) {
+ return function() {
retainedConnection = new connection.Connection(
- handle, RendererTargetTest, bindings.BrowserTargetProxy);
+ serviceRegistry.getInterface(bindings.BrowserTargetProxy.NAME_),
darin (slow to review) 2014/06/21 04:44:16 same nit about having to use NAME_ here. maybe the
Sam McNally 2014/06/24 08:45:01 Done.
+ RendererTargetTest,
+ bindings.BrowserTargetProxy);
};
});
« content/renderer/web_ui_mojo_context_state.cc ('K') | « content/renderer/web_ui_runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698