content/public/renderer/service_registry_js.h - Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/renderer/service_registry_js.h

Issue 302573002: Add a Javascript wrapper around ServiceRegistry and expose it to WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@render-view-shell

Patch Set: address comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/common/service_registry.h ('K') | « content/public/common/service_registry.h ('k') | content/renderer/service_registry_js_wrapper.h » ('j') | content/renderer/service_registry_js_wrapper.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_RENDERER_SERVICE_REGISTRY_JS_H_

	6 #define CONTENT_PUBLIC_RENDERER_SERVICE_REGISTRY_JS_H_

	7

	8 #include "content/common/content_export.h"

	9 #include "v8/include/v8.h"

	10

	11 namespace content {

	12

	13 class ServiceRegistry;

	14

	15 CONTENT_EXPORT extern const char kServiceRegistryModuleName[];

	16

	17 // Returns a JS wrapper around ServiceRegistry that allows connecting to remote

	18 // services.

	19 CONTENT_EXPORT v8::Handle<v8::Value> WrapServiceRegistry(
	darin (slow to review) 2014/06/28 21:10:38 Why does this file need to be in content/public/re Why does this file need to be in content/public/renderer/? It looks like this method and the constant only used from within content/renderer/. Perhaps you do not need to expose the GetWeakPtr() method as well if we can assume that ServiceRegistry's implementation is ServiceRegistryImpl? Sam McNally 2014/06/30 01:26:14 Done. Show quoted text On 2014/06/28 21:10:38, darin wrote: > Why does this file need to be in content/public/renderer/? It looks like this > method and the constant only used from within content/renderer/. > > Perhaps you do not need to expose the GetWeakPtr() method as well if we can > assume that ServiceRegistry's implementation is ServiceRegistryImpl? Done.
	20 v8::Isolate* isolate,

	21 ServiceRegistry* service_registry);

	22

	23 } // namespace content

	24

	25 #endif // CONTENT_PUBLIC_RENDERER_SERVICE_REGISTRY_JS_H_

OLD	NEW