content/test/layouttest_support.cc - Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/layouttest_support.cc

Issue 302553007: Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now ResetMockScreenOrientationForTesting() is called on every layout test finish, so replaced DCHEC… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/layouttest_support.cc

diff --git a/content/test/layouttest_support.cc b/content/test/layouttest_support.cc

index 9e6433bcd76e8c289afbb42f145b971ef64a4d4c..011312750c1d1dc5dc8781850f93f8842672fb3f 100644

--- a/content/test/layouttest_support.cc

+++ b/content/test/layouttest_support.cc

@@ -104,11 +104,8 @@ void SetMockDeviceOrientationData(const WebDeviceOrientationData& data) {

void SetMockScreenOrientation(

RenderView* render_view,

const blink::WebScreenOrientationType& orientation) {

- static_cast<RenderViewImpl*>(render_view)

- ->SetScreenOrientationForTesting(orientation);

- // FIXME(ostap): Remove this when blink side gets updated.

RendererWebKitPlatformSupportImpl::

- SetMockScreenOrientationForTesting(orientation);

+ SetMockScreenOrientationForTesting(render_view, orientation);

}

void ResetMockScreenOrientation()

« no previous file with comments | « content/renderer/screen_orientation/mock_screen_orientation_controller.cc ('k') | no next file » | no next file with comments »