Call RenderViewImpl::SetScreenOrientationForTesting to make sure that events are not sent when orie…

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 904716824bf6f98e2bb0b81e04e897f1f1b3a3c9..d9a9647b1c811060a776af17210ea7ac3a11cc92 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -102,6 +102,7 @@
 #include "content/renderer/render_view_mouse_lock_dispatcher.h"
 #include "content/renderer/render_widget_fullscreen_pepper.h"
 #include "content/renderer/renderer_webapplicationcachehost_impl.h"
+#include "content/renderer/renderer_webkitplatformsupport_impl.h"
 #include "content/renderer/resizing_mode_selector.h"
 #include "content/renderer/savable_resources.h"
 #include "content/renderer/skia_benchmarking_extension.h"
@@ -831,6 +832,9 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {
 }
 
 RenderViewImpl::~RenderViewImpl() {
+  if (RenderThreadImpl::current()->layout_test_mode()) {

[Inactive, 2014/05/28 12:02:20]

nit: Useless curly brackets?

[ostap, 2014/05/28 19:17:05]

Done.

+    RendererWebKitPlatformSupportImpl::ResetMockScreenOrientationRenderView();

[mlamouri (slow - plz ping), 2014/05/28 13:45:20]

Can't we make the render_view_ reset happen in
ResetMockScreenOrientationForTesting() instead? Adding things in
render_view_impl makes me uneasy and I given that we call
ResetMockScreenOrientationForTesting() between tests, we should be fine if we
reset the render_view_ member there, right?

[ostap, 2014/05/28 19:17:05]

I think using ResetMockScreenOrientationForTesting() is a good idea since it is
not necessary to introduce another method.
But I think it is still required to track render view deallocation because we
can get difficult to debug crash if one of tests fails to call
ResetMockScreenOrientationForTesting() for some reason.

[mlamouri (slow - plz ping), 2014/05/29 14:51:55]

AFAIK, we use the same RenderView during the LayoutTests so we shouldn't even
have to call this and ::Reset() is meant to be used exactly for cleaning up
things between tests. I'm not an owner of that file, but I think adding this
there isn't right.

+  }
   for (BitmapMap::iterator it = disambiguation_bitmaps_.begin();
        it != disambiguation_bitmaps_.end();
        ++it)