Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: content/renderer/media/buffered_data_source_unittest.cc

Issue 302553006: Suppress pause and buffer for local resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/buffered_data_source_unittest.cc
diff --git a/content/renderer/media/buffered_data_source_unittest.cc b/content/renderer/media/buffered_data_source_unittest.cc
index 6cf7ef42b6e5114bc4a474c5ea5c46bbdb5447ea..c6ed70d671813a21e90104fc6c0d8dcb02014b88 100644
--- a/content/renderer/media/buffered_data_source_unittest.cc
+++ b/content/renderer/media/buffered_data_source_unittest.cc
@@ -219,6 +219,10 @@ class BufferedDataSourceTest : public testing::Test {
int data_source_playback_rate() { return data_source_->playback_rate_; }
int loader_bitrate() { return loader()->bitrate_; }
int loader_playback_rate() { return loader()->playback_rate_; }
+ bool is_local_source() { return data_source_->assume_fully_buffered_; }
+ void set_might_be_reused_from_cache_in_future(bool value) {
+ loader()->might_be_reused_from_cache_in_future_ = value;
+ }
scoped_ptr<MockBufferedDataSource> data_source_;
@@ -669,4 +673,33 @@ TEST_F(BufferedDataSourceTest, File_FinishLoading) {
Stop();
}
+TEST_F(BufferedDataSourceTest, LocalResource_DeferStrategy) {
+ InitializeWithFileResponse();
+
+ EXPECT_TRUE(is_local_source());
+ EXPECT_EQ(BufferedResourceLoader::kCapacityDefer, defer_strategy());
+
+ // Test for pause-and-buffer
scherkus (not reviewing) 2014/05/30 20:37:39 nit: comments should end with periods you should
amogh.bihani 2014/06/02 05:01:28 Done.
+ data_source_->MediaIsPlaying();
+ data_source_->MediaIsPaused();
+ EXPECT_EQ(BufferedResourceLoader::kReadThenDefer, defer_strategy());
+
+ Stop();
+}
+
+TEST_F(BufferedDataSourceTest, ExternalResource_DeferStrategy) {
+ InitializeWith206Response();
+
+ EXPECT_FALSE(is_local_source());
+ EXPECT_EQ(BufferedResourceLoader::kCapacityDefer, defer_strategy());
+
+ // Test for pause-and-buffer
+ data_source_->MediaIsPlaying();
+ set_might_be_reused_from_cache_in_future(true);
amogh.bihani 2014/05/29 09:38:57 Need to do this as buffered_resource_loader set it
+ data_source_->MediaIsPaused();
+ EXPECT_EQ(BufferedResourceLoader::kNeverDefer, defer_strategy());
+
+ Stop();
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698