Suppress pause and buffer for local resources

content/renderer/media/buffered_data_source.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/buffered_data_source.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "content/public/common/url_constants.h"
@@ skipping 499 matching lines @@
   if (stop_signal_received_)
     return;
 
   host_->AddBufferedByteRange(loader_->first_byte_position(), position);
 }
 
 void BufferedDataSource::UpdateDeferStrategy(bool paused) {
   // 200 responses end up not being reused to satisfy future range requests,
   // and we don't want to get too far ahead of the read-head (and thus require
   // a restart), so keep to the thresholds.
-  if (!loader_->range_supported()) {
+  if (!loader_->range_supported() && !assume_fully_buffered_) {

[amogh.bihani, 2014/05/29 09:38:57]

in buffered_resource_loader 'range_supported_' is set to false in constructor.
This value changes only in this[1] if block. For local resources this variable
never changes as the code will not go in that if block.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/m...

     loader_->UpdateDeferStrategy(BufferedResourceLoader::kCapacityDefer);
     return;
   }
 
   // If the playback has started (at which point the preload value is ignored)
   // and we're paused, then try to load as much as possible (the loader will
   // fall back to kCapacityDefer if it knows the current response won't be
-  // useful from the cache in the future).
+  // useful from the cache in the future) for external resources. Loading data
+  // for local resources is not necessary while the player is paused.
   if (media_has_played_ && paused) {
+    if (assume_fully_buffered_) {
+      loader_->UpdateDeferStrategy(BufferedResourceLoader::kReadThenDefer);

[scherkus (not reviewing), 2014/05/30 20:37:39]

I feel like kCapacityDefer is right one to use for this case, in which case we
can simplify this code by just having a block that checks for this + move the
check higher in this function

// No need to aggressive buffer when we are assuming the resource
// is fully buffered.
if (assume_fully_buffered_) {
  loader_->UpdateDeferStrategy(BufferedResourceLoader::kCapacityDefer);
  return;
}

[amogh.bihani, 2014/06/02 05:01:28]

Done.

+      return;
+    }
     loader_->UpdateDeferStrategy(BufferedResourceLoader::kNeverDefer);
     return;
   }
 
   // If media is currently playing or the page indicated preload=auto,
   // use threshold strategy to enable/disable deferring when the buffer
   // is full/depleted.
   loader_->UpdateDeferStrategy(BufferedResourceLoader::kCapacityDefer);
 }
 
 }  // namespace content