Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Issue 302553002: Computed style of resource references drops hash from fragment (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
Reviewers:
pdr., krit
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Computed style of resource references drops hash from fragment Computed style of resource references drops hash from fragment, include it when returning the computed property value for start-marker, mid-marker, end-marker, filter, mask and clip-path. Also add a test. BUG=232904 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174910

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M LayoutTests/svg/css/getComputedStyle-basic.xhtml View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/SVGCSSComputedStyleDeclaration.cpp View 1 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rwlbuis
PTAL.
6 years, 7 months ago (2014-05-27 17:51:06 UTC) #1
pdr.
On 2014/05/27 17:51:06, rwlbuis wrote: > PTAL. LGTM
6 years, 7 months ago (2014-05-27 21:02:54 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 7 months ago (2014-05-27 21:03:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/302553002/20001
6 years, 7 months ago (2014-05-27 21:03:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 7 months ago (2014-05-27 23:03:46 UTC) #5
pdr.
The CQ bit was unchecked by pdr@chromium.org
6 years, 7 months ago (2014-05-27 23:05:20 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 7 months ago (2014-05-27 23:05:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/302553002/20001
6 years, 7 months ago (2014-05-27 23:05:38 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 23:44:42 UTC) #9
Message was sent while issue was closed.
Change committed as 174910

Powered by Google App Engine
This is Rietveld 408576698