Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: media/media.gyp

Issue 302533009: Android: cleanup gtest_target_type conditions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit on all.gyp Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | remoting/remoting_android.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/media.gyp
diff --git a/media/media.gyp b/media/media.gyp
index 4f6068be2ff580de94bb50ca7da5c64cd0e9ba92..b4b62bd25ed15d3363758adf4c9869d7d462dc44 100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -1149,13 +1149,9 @@
'filters/pipeline_integration_test.cc',
'filters/pipeline_integration_test_base.cc',
],
- 'conditions': [
- ['gtest_target_type=="shared_library"', {
- 'dependencies': [
- '../testing/android/native_test.gyp:native_test_native_code',
- 'player_android',
- ],
- }],
+ 'dependencies': [
+ '../testing/android/native_test.gyp:native_test_native_code',
+ 'player_android',
],
}],
['OS=="linux"', {
@@ -1252,13 +1248,9 @@
],
}],
['OS=="android"', {
- 'conditions': [
- ['gtest_target_type=="shared_library"', {
- 'dependencies': [
- '../testing/android/native_test.gyp:native_test_native_code',
- ],
- }],
- ],
+ 'dependencies': [
+ '../testing/android/native_test.gyp:native_test_native_code',
+ ],
}],
['media_use_ffmpeg==1', {
'dependencies': [
@@ -1517,7 +1509,7 @@
'type': 'executable',
'dependencies': [
'media',
- 'shared_memory_support',
+ 'shared_memory_support',
'../base/base.gyp:base',
'../ui/gl/gl.gyp:gl',
'../ui/gfx/gfx.gyp:gfx',
@@ -1548,9 +1540,7 @@
},
],
}],
- # Special target to wrap a gtest_target_type==shared_library
- # media_unittests into an android apk for execution.
- ['OS=="android" and gtest_target_type=="shared_library"', {
+ ['OS=="android"', {
'targets': [
{
'target_name': 'media_unittests_apk',
« no previous file with comments | « build/all.gyp ('k') | remoting/remoting_android.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698