Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 302533009: Android: cleanup gtest_target_type conditions. (Closed)

Created:
6 years, 7 months ago by bulach
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Android: cleanup gtest_target_type conditions. For a long time (crrev.com/133053) OS==android implies: gtest_target_type=shared_library Cleanup the spurious conditions and obsolete TODOs. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273203

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Nit on all.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -65 lines) Patch
M build/all.gyp View 1 3 chunks +28 lines, -40 lines 0 comments Download
M media/media.gyp View 4 chunks +8 lines, -18 lines 0 comments Download
M remoting/remoting_android.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
bulach
scherkus: media/ OWNERS lambroslambrou: remoting/ OWNERS tfarina: build/ thanks! :) (FYI, similar patch already landed ...
6 years, 7 months ago (2014-05-27 14:48:14 UTC) #1
tfarina
build/ lgtm https://codereview.chromium.org/302533009/diff/20001/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/302533009/diff/20001/build/all.gyp#newcode773 build/all.gyp:773: '../android_webview/android_webview.gyp:android_webview_test_apk', nit: alphabetical order.
6 years, 7 months ago (2014-05-27 16:10:03 UTC) #2
bulach
thanks thiago! addressed.. https://codereview.chromium.org/302533009/diff/20001/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/302533009/diff/20001/build/all.gyp#newcode773 build/all.gyp:773: '../android_webview/android_webview.gyp:android_webview_test_apk', On 2014/05/27 16:10:03, tfarina wrote: ...
6 years, 7 months ago (2014-05-27 16:14:37 UTC) #3
Lambros
remoting/ LGTM
6 years, 7 months ago (2014-05-27 17:13:05 UTC) #4
scherkus (not reviewing)
media/ lgtm
6 years, 7 months ago (2014-05-27 17:28:57 UTC) #5
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 7 months ago (2014-05-27 17:35:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/302533009/40001
6 years, 7 months ago (2014-05-27 17:36:39 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 20:35:51 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 20:37:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/78147)
6 years, 7 months ago (2014-05-27 20:37:43 UTC) #10
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 6 months ago (2014-05-28 09:52:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/302533009/40001
6 years, 6 months ago (2014-05-28 09:53:09 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 13:43:35 UTC) #13
Message was sent while issue was closed.
Change committed as 273203

Powered by Google App Engine
This is Rietveld 408576698