Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 302533007: Add .nmf generating rule for ppapi_tests. (Closed)

Created:
6 years, 7 months ago by hidehiko
Modified:
6 years, 7 months ago
CC:
chromium-reviews, hamaji, mazda, teravest
Visibility:
Public.

Description

Add .nmf generating rule for ppapi_tests. Now we introduced create_nonsfi_test_nmf.py. So, by this CL it starts to be used to generate nmf file for non-SFI ppapi_tests. Also, this CL removes ppapi_nacl_tests_pnacl_nonsfi.nmf. BUG=368949 TEST=Ran browser_tests --gtest_filter=*NonSfi* and trybots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273127

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M ppapi/ppapi_nacl.gyp View 3 chunks +16 lines, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/tests/ppapi_nacl_tests_pnacl_nonsfi.nmf View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for review in advance, - hidehiko
6 years, 7 months ago (2014-05-27 08:44:55 UTC) #1
Mark Seaborn
LGTM
6 years, 7 months ago (2014-05-27 15:23:25 UTC) #2
dmichael (off chromium)
lgtm
6 years, 7 months ago (2014-05-27 20:45:43 UTC) #3
hidehiko
The CQ bit was checked by hidehiko@chromium.org
6 years, 7 months ago (2014-05-28 01:53:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/302533007/20001
6 years, 7 months ago (2014-05-28 01:55:54 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 03:00:49 UTC) #6
Message was sent while issue was closed.
Change committed as 273127

Powered by Google App Engine
This is Rietveld 408576698