Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 30253002: Use paths relative to build dir in custom actions. (Closed)

Created:
7 years, 2 months ago by koz (OOO until 15th September)
Modified:
7 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Use paths relative to build dir in custom actions. Also inserts a space between the rule name and the inputs in the generated ninja. BUG=309227 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231304

Patch Set 1 #

Total comments: 6

Patch Set 2 : respond to comments #

Patch Set 3 : break lines to be <= 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/gn/ninja_script_target_writer.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M tools/gn/ninja_script_target_writer_unittest.cc View 1 2 3 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
koz (OOO until 15th September)
7 years, 2 months ago (2013-10-18 23:55:16 UTC) #1
koz (OOO until 15th September)
Friendly ping
7 years, 2 months ago (2013-10-22 23:34:49 UTC) #2
brettw
Sorry, I forgot about this today and tomorrow I have promo committee. I'll get back ...
7 years, 2 months ago (2013-10-23 01:57:31 UTC) #3
brettw
lgtm https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_writer.cc File tools/gn/ninja_script_target_writer.cc (right): https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_writer.cc#newcode95 tools/gn/ninja_script_target_writer.cc:95: out_ << " command = $pythonpath "; While ...
7 years, 2 months ago (2013-10-23 16:27:04 UTC) #4
koz (OOO until 15th September)
Thanks, Brett! https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_writer.cc File tools/gn/ninja_script_target_writer.cc (right): https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_writer.cc#newcode95 tools/gn/ninja_script_target_writer.cc:95: out_ << " command = $pythonpath "; ...
7 years, 2 months ago (2013-10-24 05:56:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/30253002/90001
7 years, 2 months ago (2013-10-24 05:58:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=32279
7 years, 2 months ago (2013-10-24 06:16:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/30253002/150001
7 years, 1 month ago (2013-10-28 05:32:21 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-10-28 10:05:49 UTC) #9
Message was sent while issue was closed.
Change committed as 231304

Powered by Google App Engine
This is Rietveld 408576698