Use paths relative to build dir in custom actions.

Use paths relative to build dir in custom actions.

Also inserts a space between the rule name and the inputs in the generated ninja.

BUG=309227
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231304

[koz (OOO until 15th September), 2013-10-22 23:34:49]

Friendly ping

[brettw, 2013-10-23 01:57:31]

Sorry, I forgot about this today and tomorrow I have promo committee.
I'll get back to this Thursday.

Brett

On Tue, Oct 22, 2013 at 4:34 PM,  <koz@chromium.org> wrote:
> Friendly ping
>
> https://codereview.chromium.org/30253002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[brettw, 2013-10-23 16:27:04]

lgtm

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
File tools/gn/ninja_script_target_writer.cc (right):

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer.cc:95: out_ << "  command = $pythonpath ";
While you're here, can you do WriteFile(...python_path() like we do above? I
used to use $pythonpath everywhere but this was causing problems with the GYP
integration so I'm moving to writing the path out.

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer.cc:133: out_ << ": " << custom_rule_name <<
" ";
Whoopsies! I guess I haven't done any script stuff lately.

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
File tools/gn/ninja_script_target_writer_unittest.cc (right):

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer_unittest.cc:94: "  command = $pythonpath
../../foo/script.py -i ${source} \"--out=foo$ bar${source_name_part}.o\"\n"
I guess you'll have to update this, maybe you'll need to explicitly set the
python path for the build above.

[koz (OOO until 15th September), 2013-10-24 05:56:28]

Thanks, Brett!

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
File tools/gn/ninja_script_target_writer.cc (right):

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer.cc:95: out_ << "  command = $pythonpath ";
On 2013/10/23 16:27:05, brettw wrote:
> While you're here, can you do WriteFile(...python_path() like we do above? I
> used to use $pythonpath everywhere but this was causing problems with the GYP
> integration so I'm moving to writing the path out.

Done.

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer.cc:133: out_ << ": " << custom_rule_name <<
" ";
On 2013/10/23 16:27:05, brettw wrote:
> Whoopsies! I guess I haven't done any script stuff lately.

I wondered for a bit if it was some bit of ninja syntax I hadn't yet seen :-)

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
File tools/gn/ninja_script_target_writer_unittest.cc (right):

https://codereview.chromium.org/30253002/diff/1/tools/gn/ninja_script_target_...
tools/gn/ninja_script_target_writer_unittest.cc:94: "  command = $pythonpath
../../foo/script.py -i ${source} \"--out=foo$ bar${source_name_part}.o\"\n"
On 2013/10/23 16:27:05, brettw wrote:
> I guess you'll have to update this, maybe you'll need to explicitly set the
> python path for the build above.

Done.

[commit-bot: I haz the power, 2013-10-24 05:58:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/30253002/90001

[commit-bot: I haz the power, 2013-10-24 06:16:22]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-10-28 05:32:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/koz@chromium.org/30253002/150001

[commit-bot: I haz the power, 2013-10-28 10:05:49]

Change committed as 231304