Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 302513002: Ensure min size (20 dip) for images used in ImageGrid (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure min size for images used in ImageGrid A workaround until ImageGrid switches to cc::NinePatchLayer. BUG=376519 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273046

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -63 lines) Patch
M ui/wm/core/image_grid.h View 3 chunks +13 lines, -18 lines 0 comments Download
M ui/wm/core/image_grid.cc View 6 chunks +77 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
6 years, 7 months ago (2014-05-27 16:13:04 UTC) #1
ccameron
This lgtm Yes, indeed is a bit on the hacky side. I'll try to get ...
6 years, 7 months ago (2014-05-27 17:45:33 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-27 17:57:13 UTC) #3
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-05-27 17:59:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/302513002/40001
6 years, 7 months ago (2014-05-27 18:00:02 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 21:55:51 UTC) #6
Message was sent while issue was closed.
Change committed as 273046

Powered by Google App Engine
This is Rietveld 408576698