athena: Add a minimal executable for just the UI.

athena: Add a minimal executable for just the UI.

athena_ui_main is a small executable that creates an aura host window
and builds the athena UI on it. This should make it easier to play with
the UI (a la ash_shell etc.)

BUG=362288
R=oshima@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273718

[sadrul, 2014-05-26 18:53:01]

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc
File athena/ui/athena_ui_main.cc (right):

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc#...
athena/ui/athena_ui_main.cc:57: void InitAthenaUI() {
Does it make sense to move this into some other place that both athena_main and
athena_ui_main can use? So we have one place to update instead of two?

[oshima, 2014-05-27 18:32:14]

You beats me to it. I feel it's overkill to have separate directory for this
though. Can you just add new target (athena_shell ?) in athena/main?

https://codereview.chromium.org/302473005/diff/1/athena/screen/background_con...
File athena/screen/background_controller.cc (right):

https://codereview.chromium.org/302473005/diff/1/athena/screen/background_con...
athena/screen/background_controller.cc:28: if (!image_.isNull()) {
can you set the background using SetupBackgroundImage()? I'd like to minimize
the difference in execution path between environments.

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc
File athena/ui/athena_ui_main.cc (right):

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc#...
athena/ui/athena_ui_main.cc:57: void InitAthenaUI() {
On 2014/05/26 18:53:01, sadrul wrote:
> Does it make sense to move this into some other place that both athena_main
and
> athena_ui_main can use? So we have one place to update instead of two?

You can use athena_launcher once it's landed.

https://codereview.chromium.org/301593004/

[sadrul, 2014-05-29 03:03:56]

On 2014/05/27 18:32:14, oshima wrote:
> You beats me to it. I feel it's overkill to have separate directory for this
> though. Can you just add new target (athena_shell ?) in athena/main?

Done.

https://codereview.chromium.org/302473005/diff/1/athena/screen/background_con...
File athena/screen/background_controller.cc (right):

https://codereview.chromium.org/302473005/diff/1/athena/screen/background_con...
athena/screen/background_controller.cc:28: if (!image_.isNull()) {
On 2014/05/27 18:32:14, oshima wrote:
> can you set the background using SetupBackgroundImage()? I'd like to minimize
> the difference in execution path between environments.

Done.

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc
File athena/ui/athena_ui_main.cc (right):

https://codereview.chromium.org/302473005/diff/1/athena/ui/athena_ui_main.cc#...
athena/ui/athena_ui_main.cc:57: void InitAthenaUI() {
On 2014/05/27 18:32:14, oshima wrote:
> On 2014/05/26 18:53:01, sadrul wrote:
> > Does it make sense to move this into some other place that both athena_main
> and
> > athena_ui_main can use? So we have one place to update instead of two?
> 
> You can use athena_launcher once it's landed.
> 
> https://codereview.chromium.org/301593004/

Done.

[oshima, 2014-05-29 05:19:33]

lgtm with nit and optional suggestion

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell.cc
File athena/main/athena_shell.cc (right):

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:8: #include "athena/wm/public/window_manager.h"
nit: I think you don't need home_card, screen_manager and window_manager.h

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:21: #include "ui/wm/test/wm_test_helper.h"
optional: does it make sense to use athena/test/athena_test_helper instead?

[oshima, 2014-05-29 14:54:22]

slgtm

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell.cc
File athena/main/athena_shell.cc (right):

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:55: visibility_controller_.get());
one more nit. StartAthena does this, so you don't need this.

[sadrul, 2014-05-30 02:29:48]

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell.cc
File athena/main/athena_shell.cc (right):

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:8: #include "athena/wm/public/window_manager.h"
On 2014/05/29 05:19:33, oshima wrote:
> nit: I think you don't need home_card, screen_manager and window_manager.h

Done.

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:21: #include "ui/wm/test/wm_test_helper.h"
On 2014/05/29 05:19:33, oshima wrote:
> optional: does it make sense to use athena/test/athena_test_helper instead?

Done.

https://codereview.chromium.org/302473005/diff/20001/athena/main/athena_shell...
athena/main/athena_shell.cc:55: visibility_controller_.get());
On 2014/05/29 14:54:23, oshima wrote:
> one more nit. StartAthena does this, so you don't need this.

Nice. Done.

[sadrul, 2014-05-30 05:23:07]

Committed patchset #4 manually as r273718 (presubmit successful).

[tfarina, 2014-05-30 05:36:41]

You forgot to update the CL description:

s/athena_ui_main/athena_shell. ;)