Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 302463005: Add support for AMD to the extensions module system. (Closed)

Created:
6 years, 7 months ago by Sam McNally
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add support for AMD to the extensions module system. This allows extensions modules to be implemented using AMD and supports dependencies between modules of both types. AMD support is necessary to use Mojo bindings in the implementation of app/extension APIs. This also merges the native and non-native module namespaces. Superseded by https://codereview.chromium.org/359413004/

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -218 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/app_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/app_window_custom_bindings.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/browser_action_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/media_galleries_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/tabs_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/webstore_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/module_system_test.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/test/base/module_system_test.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M extensions/renderer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M extensions/renderer/module_system.h View 5 chunks +19 lines, -10 lines 0 comments Download
M extensions/renderer/module_system.cc View 6 chunks +172 lines, -68 lines 0 comments Download
M extensions/renderer/resources/app_runtime_custom_bindings.js View 1 chunk +51 lines, -46 lines 0 comments Download
M extensions/renderer/resources/entry_id_manager.js View 1 chunk +49 lines, -44 lines 0 comments Download
M extensions/renderer/resources/extension_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/i18n_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/last_error.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/runtime_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/send_request.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/set_icon.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resources/utils.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/script_context.h View 3 chunks +11 lines, -1 line 0 comments Download
M extensions/renderer/script_context.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M extensions/renderer/script_context_set_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M extensions/renderer/v8_schema_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M gin/modules/module_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam McNally
6 years, 6 months ago (2014-06-16 08:15:58 UTC) #1
not at google - send to devlin
Wow. Ok. Is there an associated bug anywhere I can read up on, or a ...
6 years, 6 months ago (2014-06-16 15:01:49 UTC) #2
raymes
6 years, 6 months ago (2014-06-19 01:38:59 UTC) #3
benwells
On 2014/06/19 01:38:59, raymes wrote: +1 to getting a design doc for this, it is ...
6 years, 6 months ago (2014-06-19 22:51:42 UTC) #4
benwells
6 years, 6 months ago (2014-06-19 22:59:48 UTC) #5 
On 2014/06/19 22:51:42, benwells wrote:
> On 2014/06/19 01:38:59, raymes wrote:
> 
> +1 to getting a design doc for this, it is a significant change.

And +1000 for logging a bug.

Powered by Google App Engine
This is Rietveld 408576698